This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb9ee2acc9c5c: [LinkerWrapper] report on missing libraries
(authored by jhuber6).
Changed prior to commit:
https://reviews.llvm.org/D137180?vs=4723
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137180/new/
https://reviews.llvm.org/D137180
___
jhuber6 added inline comments.
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278
+ if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive)
+continue;
+
jdoerfert wrote:
> jhuber6 wrote:
> > jdoerfert wrote:
> >
jdoerfert added inline comments.
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278
+ if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive)
+continue;
+
jhuber6 wrote:
> jdoerfert wrote:
> > So if the library i
jhuber6 added inline comments.
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278
+ if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive)
+continue;
+
jdoerfert wrote:
> So if the library is found but not an ar
jdoerfert added inline comments.
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278
+ if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive)
+continue;
+
So if the library is found but not an archive we silently
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, JonChesterfield.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The linker wrapper does its own library searching
