This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb1bc723dfe97: [Clang] refactor CodeGenFunction::EmitAsmStmt
NFC (authored by nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
nickdesaulniers updated this revision to Diff 498209.
nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.
- fix bugprone-argument-comment as per @shafik
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https:
nickdesaulniers updated this revision to Diff 498156.
nickdesaulniers added a comment.
- final rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/li
shafik added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:2405
+ QualType Ty =
+ CGF.getContext().getIntTypeForBitwidth(Size, /*Signed*/ false);
+ if (Ty.isNull()) {
To be consistent with
[bugprone-argument-comment](https://clang.
nickdesaulniers updated this revision to Diff 495174.
nickdesaulniers added a comment.
- rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/lib/Code
void accepted this revision.
void added a comment.
Still LGTM :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
___
cfe-commits mailing list
cfe-commits@lists
nickdesaulniers updated this revision to Diff 490245.
nickdesaulniers added a comment.
- rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/lib/Code
nickdesaulniers updated this revision to Diff 487927.
nickdesaulniers added a comment.
- rebase, format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/
nickdesaulniers updated this revision to Diff 484672.
nickdesaulniers added a comment.
- rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/lib/Code
nickdesaulniers updated this revision to Diff 480992.
nickdesaulniers added a comment.
- rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/lib/Code
void accepted this revision.
void added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
___
nickdesaulniers updated this revision to Diff 472132.
nickdesaulniers added a comment.
- move asserts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
Files:
clang/lib/CodeGen/CGStmt.cpp
Index: clang/li
nickdesaulniers planned changes to this revision.
nickdesaulniers added a comment.
Let me move the asserts, too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137113/new/
https://reviews.llvm.org/D137113
___
nickdesaulniers created this revision.
nickdesaulniers added reviewers: void, nikic, jyknight, efriedma, craig.topper.
Herald added a subscriber: StephenFan.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe
14 matches
Mail list logo
