[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

2022-11-16 Thread Eli Friedman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fcb26c5b648: [clang] Fix __try/__finally blocks in C++ constructors. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

2022-10-27 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. From what I know, we could always build the GlobalDecl with the base ctor/dtor variant. The complete and deleting variants always delegate to the base variants, and we will only ever emit the SEH fu

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

2022-10-27 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo resigned from this revision. mstorsjo added a comment. Sorry, I know essentially nothing about this area... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136776/new/ https://reviews.llvm.org/D136776 ___

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

2022-10-26 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added reviewers: rjmccall, rnk, mstorsjo. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. We were crashing trying to construct a GlobalDecl from a CXXConstructorDecl in the mangler. Instead of trying