[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

2023-01-24 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added inline comments. Comment at: clang/test/Driver/SOURCE_DATE_EPOCH.c:2 +// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH +// NO_EPOCH-NOT: "-source-date-epoch" + tstellar wrote: > Hi @benlangmuir, this test fails in our build e

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

2023-01-24 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Comment at: clang/test/Driver/SOURCE_DATE_EPOCH.c:2 +// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH +// NO_EPOCH-NOT: "-source-date-epoch" + Hi @benlangmuir, this test fails in our build environment, because w

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

2022-10-26 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4324 +if (Epoch.getAsInteger(10, V) || V > MaxTimestamp) { Diags.Report(diag::err_fe_invalid_source_date_epoch) << Epoch << MaxTimestamp; benlangmuir wr

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

2022-10-26 Thread Ben Langmuir via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG211f5af38af1: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC (authored by benlangmuir). Herald added a project: clang. Herald add