[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

2022-10-26 Thread Balázs Kéri via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa688b5f92a17: [clang][ASTImporter] Remove use of ParentMapContext. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136684/new/ https:/

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

2022-10-26 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D136684#3884983 , @balazske wrote: > This is really a NFC-like change but not NFC because it has visible effects > of removing some crashes. I could not produce a test that provokes the wrong > case (when `getParents` returns

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

2022-10-26 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. This is really a NFC-like change but not NFC because it has visible effects of removing some crashes. I could not produce a test that provokes the wrong case (when `getParents` returns an empty list). Is it enough to have no new test here? If we can get a test for the

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

2022-10-25 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. It is very good that we can get rid of the `ParentMapContext` because it was sub-optimal to build that up for **//all//** declaration contexts of the tra

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

2022-10-25 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs