[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d1ff787e5c2: [AArch64] Add support for the Cortex-X3 CPU (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 474029. vhscampos added a comment. Rebasing and conflict resolution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseNotes.rst clang/tes

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

tschuett added a comment. In D136589#3915126 , @vhscampos wrote: > @tschuett Do you still want me to put the note about 'native' detection for > neoverse-v2 back? Up to you. No worries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added a comment. @tschuett Do you want me to put the note about 'native' detection for neoverse-v2 back? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM if there are not other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 _

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472583. vhscampos added a comment. Added SSBS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/aarch64-mcpu.

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. vhscampos wrote: > tschuett wrote: > > d

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos marked an inline comment as done. vhscampos added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. ---

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472567. vhscampos added a comment. Added AEK_FLAM to the list of features for Cortex-X3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseN

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

tschuett added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. dmgreen wrote: > tschuett wrote: > > Wh

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added a subscriber: david-arm. dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. t

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

tschuett added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. What happened with native detection?

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added a comment. Thanks. What was wrong with the v9-A features? Comment at: llvm/unittests/Support/TargetParserTest.cpp:1083 + AArch64::AEK_SVE | AArch64::AEK_SVE2 | + AArch64::AEK_SVE2BITPERM | AArch64::AEK_SB | +

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472001. vhscampos added a comment. Combining release notes of Cortex-X3 and Neoverse V2. Make cortex-x3 use neoverse-v2 model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.o

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:629-631 - Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. Native detection is also supported via ``-mcpu=native``. +- Support has been added for the following processors

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos planned changes to this revision. vhscampos added a comment. We found an issue in the list of target features for v9-A. This patch will be affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D1365

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added support for the Cortex-X3 CPU. + vhscampos wrote: > dmgreen wrote: > > Can you add a reference to neoverse-v2 too. > I could do this in another patch, but I prefer to restrict t

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added support for the Cortex-X3 CPU. + dmgreen wrote: > Can you add a reference to neoverse-v2 too. I could do this in another patch, but I prefer to restrict this one to X3. Reposi

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 470449. vhscampos marked 2 inline comments as done. vhscampos added a comment. Comments addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/doc

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added a comment. Can you also add a test to clang/test/Driver/aarch64-mcpu.c and the right code to llvm/lib/Support/Host.cpp if you can find it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 __

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added reviewers: lenary, dmgreen. dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:397 configuration files. +- Support has been added for the following processors (-mcpu identifiers in parentheses): + This should be in the "Arm a

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Cortex-X3 is an Armv9-A AArch64 CPU. This patch i