erichkeane added a subscriber: aaron.ballman.
erichkeane added a comment.
See @aaron.ballman 's comment here:
https://github.com/llvm/llvm-project/issues/59271
Since the release branch is pending, if we don't have a solution or a revert by
the 13th, Aaron or I will revert this patch.
Reposito
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0a6de59c780: [clang] Instantiate concepts with sugared
template arguments (authored by mizvekov).
Changed prior to commit:
https://reviews.llvm.org/D136566?vs=470013&id=470671#toc
Repository:
rG LLV
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaConcept.cpp:1079
MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs(
- CSE->getNamedConcept(), /*Final=*/false, &TAL,
+ CSE->getNamedConcept(), /*Final=*/true, &TAL,
/*Relative
mizvekov added inline comments.
Comment at: clang/lib/Sema/SemaConcept.cpp:1079
MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs(
- CSE->getNamedConcept(), /*Final=*/false, &TAL,
+ CSE->getNamedConcept(), /*Final=*/true, &TAL,
/*RelativeTo
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
This is an improvement, thanks!
Comment at: clang/lib/Sema/SemaConcept.cpp:1079
MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs(
- CSE->
mizvekov created this revision.
Herald added a project: All.
mizvekov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Since we don't unique specializations for concepts, we can just instantiate
them with the sugared template arguments, at n
