[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

2022-10-24 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37e754e5801c: [clang-format] Insert closing braces after an unaffected line (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

2022-10-23 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 469969. owenpan added a comment. This revision is now accepted and ready to land. Fixed assertion failures on the tests in https://github.com/llvm/llvm-project/issues/58161#issuecomment-1287904972. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13643

[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

2022-10-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan planned changes to this revision. owenpan added a comment. The assertions failed on the new examples in #58161. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13643

[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

2022-10-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D136437#3874832 , @MyDeveloperDay wrote: > Does this need a unit test? or are we good? I will add the tests from https://github.com/llvm/llvm-project/issues/58161 in another patch after moving InsertBraces tests out of Forma