This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd239f3c627a3: [clang][deps] Remove unintentional `move`
(authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
As it happens the bot that found this has been moved to silent for other
reasons. I'll let you know if we see any further issues.
Repository:
rG LLVM Github Monorepo
CH
jansvoboda11 added inline comments.
Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:18
//
-// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 4 -format
experimental-full \
+// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 1 -format
jansvoboda11 updated this revision to Diff 468555.
jansvoboda11 added a comment.
Use both `-j 1` and `-j 4` in tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136124/new/
https://reviews.llvm.org/D136124
Files:
clang/lib/Tooling/DependencyS
jansvoboda11 added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:400
+auto OverlayFS =
+llvm::makeIntrusiveRefCnt(BaseFS);
auto InMemoryFS =
DavidSpickett wrote:
> Is this equivalent?
> ```
> auto
DavidSpickett added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:400
+auto OverlayFS =
+llvm::makeIntrusiveRefCnt(BaseFS);
auto InMemoryFS =
Is this equivalent?
```
auto OverlayFS = BaseFS;
```
G
jansvoboda11 created this revision.
jansvoboda11 added a reviewer: DavidSpickett.
Herald added a subscriber: ributzka.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a fix related to D13541
