loladiro added a subscriber: loladiro.
loladiro added a comment.
Thanks for this. I was about to create the same patch (after seeing this broken
on 3.7) only to see it had already been done!
Repository:
rL LLVM
http://reviews.llvm.org/D13610
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251734: [CodeGen] Call SetInternalFunctionAttributes to
attach function (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D13610?vs=37001&id=38835#toc
Repository:
rL LLVM
http
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
ahatanak added a comment.
The patch isn't fixing any serious bugs, but is fixing what seems to me
inconsistencies in the code. It makes the following changes:
1. Currently, SetLLVMFunctionAttributes is called to add function attributes to
the internal function definitions, but SetLLVMFunctionAt
echristo added a comment.
Can you give me some more background here? I'm not sure I see what's wrong and
what's going wrong.
Thanks!
-eric
http://reviews.llvm.org/D13610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
ahatanak added a comment.
Add a comment to send this patch to cfe-commits.
http://reviews.llvm.org/D13610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
