[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde9731b7033f: [clang][lex] Avoid `DirectoryLookup` copies (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019 ___

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 updated this revision to Diff 469385. jansvoboda11 added a comment. Remove regression tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019 Files: clang/lib/Lex/HeaderSearch.cpp Index: c

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

ributzka added inline comments. Comment at: clang/test/Modules/file-manager-lookup-count.m:73 +// RUN: FileCheck --input-file %t/stats %s +// CHECK: { +// CHECK-NEXT: "file-search.NumDirCacheMisses": 156, The content of the stats file may change over time,

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 updated this revision to Diff 469077. jansvoboda11 added a comment. Add regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Mo

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 added a comment. In D136019#3860557 , @ributzka wrote: > We could invoke clang with the `-stats` option and compare the result against > the expected number of stat calls. The `-stats-file=` option only tells you how many times Clang reques

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

ributzka added a comment. We could invoke clang with the `-stats` option and compare the result against the expected number of stat calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

vsapsai added a comment. The change looks good to me. And based on the scope of D121685 it should be sufficient. Do you have any ideas for testing? If it would require significant testing infrastructure work, we can do that separately. But if you have some sim

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 created this revision. jansvoboda11 added reviewers: ributzka, friss, vsapsai, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a performance regression introd