[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-27 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e720e6adad1: [X86] Add AVX-IFMA instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-27 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 471350. FreddyYe added a comment. Rebase. THX for all of the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-27 Thread Kan Shengchen via Phabricator via cfe-commits
skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-27 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 471033. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/Rel

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-26 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Headers/avxifmaintrin.h:36 +/// __m128i +/// _mm_madd52hi_avx_epu64 (__m128i __X, __m128i __Y, __m128i __Z) +/// \endcode FreddyYe wrote: > pengfei wrote: > > Should we provide unified intrinsic `_mm_madd52hi_e

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: clang/lib/Headers/avxifmaintrin.h:36 +/// __m128i +/// _mm_madd52hi_avx_epu64 (__m128i __X, __m128i __Y, __m128i __Z) +/// \endcode pengfei wrote: > Should we provide unified intrinsic `_mm_madd52hi_epu64` like AVXVNNI?

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 471022. FreddyYe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/BuiltinsX8

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 471014. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments and update. THX for review: Added llvm/test/CodeGen/X86/stack-folding-int-avx512ifma.ll and llvm/test/CodeGen/X86/stack-folding-int-avxifma.ll. Repository: rG L

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-24 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1335-1338 TARGET_BUILTIN(__builtin_ia32_vpmadd52huq128, "V2OiV2OiV2OiV2Oi", "ncV:128:", "avx512ifma,avx512vl") TARGET_BUILTIN(__builtin_ia32_vpmadd52huq256, "V4OiV4OiV4OiV4Oi", "ncV:256:", "a

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-21 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 469529. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files:

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-21 Thread Kan Shengchen via Phabricator via cfe-commits
skan added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__AVXIFMA__"); + Builder.defineMacro("__AVXIFMA_SUPPORTED__"); if (HasAVXVNNI) Why do we need this line? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/avxifma-builtins.c:1 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +avxifma -emit-llvm -o - -Wall -Werror | FileCheck %s + 32-bit test coverage?