[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-11-03 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdbe296853b1: [clang-format] Fix lambda formatting in conditional (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-26 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:336 + Previous.MatchingParen && Previous.MatchingParen->Previous && + Previous.MatchingParen->Previous->is(tok::r_brace) && + Previous.MatchingParen->Previous->MatchingP

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-26 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks updated this revision to Diff 470914. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Format/ContinuationIndenter.c

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-24 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:336 + Previous.MatchingParen && Previous.MatchingParen->Previous && + Previous.MatchingParen->Previous->is(tok::r_brace) && + Previous.MatchingParen

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-24 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks updated this revision to Diff 470272. HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added a comment. Override in `canBreak()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Form

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D135918#3857711 , @HazardyKnusperkeks wrote: > Fun fact, there is one instance of such a case within the clang-format code. > I can't remember where (I stumbled upon this in January, and tried to fix it > ever since), should

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-13 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Fun fact, there is one instance of such a case within the clang-format code. I can't remember where (I stumbled upon this in January, and tried to fix it ever since), should that be reformatted with this patch, or with a follow up? Comment

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

2022-10-13 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a