This revision was automatically updated to reflect the committed changes.
Closed by commit rG86674f66cc78: [HLSL] Added HLSL this as a reference
(authored by gracejennings, committed by python3kgae).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1357
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: clang/test/AST/HLSL/RWBuffer-AST.hlsl:49-50
// CHECK-NEXT: ArraySubscriptExpr 0x{{[0-9A-Fa-f]+}} <>
'element_type' lvalue
-// CHE
gracejennings updated this revision to Diff 473304.
gracejennings added a comment.
- Add assignment overload codegen test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135721/new/
https://reviews.llvm.org/D135721
Files:
clang/lib/AST/ExprClassif
beanz added inline comments.
Comment at: clang/test/AST/HLSL/RWBuffer-AST.hlsl:49-50
// CHECK-NEXT: ArraySubscriptExpr 0x{{[0-9A-Fa-f]+}} <>
'element_type' lvalue
-// CHECK-NEXT: MemberExpr 0x{{[0-9A-Fa-f]+}} <> 'element_type *'
lvalue ->h 0x{{[0-9A-Fa-f]+}}
-// CHECK-NEXT: CX
aaron.ballman added a comment.
Generally looking good to me aside from a test change that I don't quite
understand yet.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(),
gracejennings added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
aaron.ball
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
beanz wrot
beanz added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
aaron.ballman wrot
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
gracejenni
gracejennings marked an inline comment as done.
gracejennings added inline comments.
Comment at: clang/include/clang/AST/ExprCXX.h:1158-1161
+ static CXXThisExpr *Create(const ASTContext &C, SourceLocation Loc,
+ QualType Ty, bool IsImplicit) {
+r
gracejennings updated this revision to Diff 472791.
gracejennings marked an inline comment as done.
gracejennings added a comment.
- Add codegen test and fix member implicit this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135721/new/
https://rev
aaron.ballman added a comment.
Thank you for your patience while I sat and thought about this for a while. I'm
not against the idea, but I've definitely got some design concerns with it
which I've pointed out in the review. I think this also needs considerably more
testing of the codegen and se
python3kgae added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
gracejenning
gracejennings marked 5 inline comments as done.
gracejennings added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprVa
python3kgae added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
gracejenning
gracejennings added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
python3kga
python3kgae added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
gracejenning
gracejennings marked an inline comment as done.
gracejennings added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprVa
gracejennings updated this revision to Diff 466964.
gracejennings added a comment.
Includng formatting update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135721/new/
https://reviews.llvm.org/D135721
Files:
clang/include/clang/AST/ExprCXX.h
c
gracejennings updated this revision to Diff 466962.
gracejennings added a comment.
Formatting
Added new line file ending
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135721/new/
https://reviews.llvm.org/D135721
Files:
clang/test/AST/HLSL/this-
python3kgae added inline comments.
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179
+AST, SourceLocation(),
+Constructor->getThisType().getTypePtr()->getPointeeType(), true);
+This->setValueKind(ExprValueKind::VK_LValue);
Should this
beanz added a reviewer: aaron.ballman.
beanz added a subscriber: aaron.ballman.
beanz added a comment.
Looping in @aaron.ballman here too because this is a bit of a fun one... I know
Aaron loves when we show him the best of HLSL 😄
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
bob80905 added inline comments.
Comment at: clang/test/AST/HLSL/this-reference.hlsl:62
+// CHECK-NEXT:`-ImplicitCastExpr 0x{{[0-9A-Fa-f]+}} 'Pair' lvalue
+// CHECK-NEXT:`-CXXThisExpr 0x{{[0-9A-Fa-f]+}} 'PairInfo' lvalue
implicit this
One small nitpick I've r
gracejennings created this revision.
gracejennings added reviewers: python3kgae, beanz, pow2clk, bob80905.
Herald added a subscriber: Anastasia.
Herald added a project: All.
gracejennings requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This
24 matches
Mail list logo
