[PATCH] D135657: add time traces for AST serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG12d007d4ba21: [clang][modules] Add time traces for AST serialization (authored by Trass3r, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 added a comment. In D135657#3865581 , @Trass3r wrote: > Thanks, could you also commit it? I don't have the rights. Sure. What name and email do you want me to associate with the commit? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. Thanks, could you also commit it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 ___ cfe-commits mailing list

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 __

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. It looks like this: F24958018: image.png F24958020: image.png There is a generic test for the TimeTraceScope functionality. Other than that there's only this one I found in https://reviews.llvm.org/

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 added a comment. This looks good to me in principle. It would be nice to have a simple test that shows what kind of output we get. Can you add that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D1

[PATCH] D135657: add time traces for AST serialization

Trass3r updated this revision to Diff 466921. Trass3r retitled this revision from "add time traces for loading PCH files" to "add time traces for AST serialization". Trass3r edited the summary of this revision. Trass3r added a reviewer: jansvoboda11. Trass3r added a comment. rebased Repository: