[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

2022-10-08 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb34cc462ff: [clangd] FindTarget: UsingEnumDecl is not an alias (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135506/new/ https://

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

2022-10-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D135506#3844919 , @tom-anders wrote: > lgtm, thanks! With this change in place, we could probably ajdust > `pickDeclToUse` in Hover.cpp (introduced in https://reviews.llvm.org/D133664) > to also check for `UsingDecl` inste

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

2022-10-08 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. lgtm, thanks! With this change in place, we could probably ajdust `pickDeclToUse` in Hover.cpp (introduced in https://reviews.llvm.org/D133664) to also check for `UsingDecl` instead of

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

2022-10-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: tom-anders. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: