[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

2022-10-09 Thread Jacob Abraham via Phabricator via cfe-commits
jacob-abraham updated this revision to Diff 466386. jacob-abraham added a comment. fixed unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

2022-10-08 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. The clang-format tests are (mainly) in `clang/unittests/Format/FormatTest.cpp`, please put it there. You should have a Format-Tests (or similar) build target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

2022-10-07 Thread Jacob Abraham via Phabricator via cfe-commits
jacob-abraham updated this revision to Diff 466166. jacob-abraham added a comment. Fix patch, sorry about that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/test/Format/macro.cpp

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

2022-10-07 Thread Jacob Abraham via Phabricator via cfe-commits
jacob-abraham updated this revision to Diff 466165. jacob-abraham added a comment. Added regression test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 Files: clang/test/Format/macro.cpp Index: clang/test/Format/macro.cpp

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

2022-10-07 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Please add a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

2022-10-06 Thread Jacob Abraham via Phabricator via cfe-commits
jacob-abraham created this revision. jacob-abraham added reviewers: djasper, Typz. jacob-abraham added a project: clang-format. Herald added a project: All. jacob-abraham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This solves the issue