This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f3b0b417143: [clang] adds
`__reference_constructs_from_temporary` (authored by cjdb).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135341/new/
https://reviews.llvm.org/D135341
___
cjdb updated this revision to Diff 556693.
cjdb marked an inline comment as done.
cjdb added a comment.
partially reverts change and fixes typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135341/new/
https://reviews.llvm.org/D135341
Files:
cla
cor3ntin added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515
+ QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U,
UnaryTransformType::RemoveCVRef, {}), {});
+ return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr,
TPtr,
cjdb added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515
+ QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U,
UnaryTransformType::RemoveCVRef, {}), {});
+ return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr,
TPtr, RPa
cor3ntin added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515
+ QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U,
UnaryTransformType::RemoveCVRef, {}), {});
+ return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr,
TPtr,
h-vetinari added inline comments.
Comment at: clang/www/cxx_status.html:297
+ trait builtin, with which
std::reference_constructs_from_temporary
+ implemented. __reference_converts_from_temporary needs to be
provided, following the normal cross-vendo
cjdb added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:33
#include "clang/Basic/TypeTraits.h"
+#include "clang/Basic/TokenKinds.h"
#include "clang/Lex/Preprocessor.h"
cor3ntin wrote:
> Superfluous change
Nice catch!
Repository:
rG LLVM Githu
cjdb updated this revision to Diff 556609.
cjdb marked 3 inline comments as done.
cjdb added a comment.
- responds to @cor3ntin's feedback
- updates commit message to include `[clang]` tag and also indicate this is a
revert
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
erichkeane added a comment.
All of @cor3ntin 's suggestions are really good ones, I'm ok with this once he
is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135341/new/
https://reviews.llvm.org/D135341
cor3ntin added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:33
#include "clang/Basic/TypeTraits.h"
+#include "clang/Basic/TokenKinds.h"
#include "clang/Lex/Preprocessor.h"
Superfluous change
Comment at: clang/lib/Sema/SemaExprC
cjdb added a comment.
Sorry, I had read @erichkeane's LGTM and taken that as actually approved. Would
you like me to revert?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135341/new/
https://reviews.llvm.org/D135341
__
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe1bfeb6bcc62: adds `__reference_constructs_from_temporary`
(author
cjdb updated this revision to Diff 556499.
cjdb added a comment.
I somehow made cxx_status.html worse in the previous commit, not better
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135341/new/
https://reviews.llvm.org/D135341
Files:
clang/docs
cjdb updated this revision to Diff 556497.
cjdb retitled this revision from "[clang] adds
`__reference_constructs_from_temporary`" to "adds
`__reference_constructs_from_temporary`".
cjdb edited the summary of this revision.
cjdb added a comment.
Corrects cxx_status.html, which accidentally dupli
15 matches
Mail list logo
