This revision was automatically updated to reflect the committed changes.
Closed by commit rG561443818a15: [clangd] Optimize
Dex::generateProximityURIs(). (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135226/new/
https://rev
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:358
+// Returns^
+const char *findPathInURI(const char *S) {
+ // Skip over scheme.
adamcz wrote:
> Is there a reason why you're doing this with manual manipulation o
sammccall updated this revision to Diff 465492.
sammccall added a comment.
pointers -> StringRef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135226/new/
https://reviews.llvm.org/D135226
Files:
clang-tools-extra/clangd/index/dex/Dex.cpp
clang
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:358
+// Returns^
+const char *findPathInURI(const char *S) {
+ // Skip over scheme.
Is there a reason why you're doing this with manual manipulation of C-strings
instea
sammccall created this revision.
sammccall added a reviewer: adamcz.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Pro
