[PATCH] D135192: Fix incorrect check for running out of source locations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b773dcd2de0: Fix incorrect check for running out of source locations. (authored by ppluzhnikov, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a comment. In D135192#3866294 , @dblaikie wrote: > Sounds good (guess this is pretty impractical to have a regression test/would > require very large files to test?) Yea, overflowing this requires a very convoluted setup; I don't think

[PATCH] D135192: Fix incorrect check for running out of source locations.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good (guess this is pretty impractical to have a regression test/would require very large files to test?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a comment. Richard, ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135192/new/ https://reviews.llvm.org/D135192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a reviewer: HAPPY. ppluzhnikov added a comment. Richard, could you take a look? You've added the check in commit 78d81ecfc38c2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135192/new/ https://reviews.llvm.org/D135192 __

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov created this revision. Herald added a project: All. ppluzhnikov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When CurrentLoadedOffset is less than TotalSize, current code will trigger unsigned overflow and will not return an