[PATCH] D134921: [HLSL] add cos library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG9777e98a610f: [HLSL] add cos library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ ht

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 475861. bob80905 added a comment. - clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/CodeG

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 475633. bob80905 added a comment. - remove int overloads - remove double - update tests after new builtin landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 File

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464447. bob80905 added a comment. revert revision, remove int overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsi

[PATCH] D134921: [HLSL] add cos library function

python3kgae added a comment. In D134921#3828545 , @bob80905 wrote: > - lower cos to llvm This will affect things outside HLSL. Please create a new PR without HLSL related part. Sorry I didn't make things clear before :(. You can copy what https://gith

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464428. bob80905 added a comment. - lower cos to llvm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/include/clang/Basic/Builtins.def clang/lib/Cod

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464407. bob80905 added a comment. - remove double Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/Code

[PATCH] D134921: [HLSL] add cos library function

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/cos.hlsl:11 +// NO_HALF: define noundef float @"?test_cos_half@@YA$halff@$halff@@Z"( +// NO_HALF: call noundef float @"?cos@@YAMM@Z"(float noundef %0) +half test_cos_half ( half p0 ) {

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464091. bob80905 added a comment. - remove int overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/te

[PATCH] D134921: [HLSL] add cos library function

python3kgae added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_intrinsics.h:111 +int16_t3 cos(int16_t3); +__attribute__((clang_builtin_alias(__builtin_elementwise_cos))) +int16_t4 cos(int16_t4); why there're integer overloads? Repository: rG LLVM

[PATCH] D134921: [HLSL] add cos library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the cos l