[PATCH] D134319: [HLSL] add ceil library function

2022-09-29 Thread Xiang Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbe07c80cf777: [HLSL] add ceil library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ h

[PATCH] D134319: [HLSL] add ceil library function

2022-09-29 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 463960. bob80905 added a comment. - got clang-format working on VS2022 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsic

[PATCH] D134319: [HLSL] add ceil library function

2022-09-28 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 463720. bob80905 added a comment. - whitespace try 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/C

[PATCH] D134319: [HLSL] add ceil library function

2022-09-28 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 463680. bob80905 added a comment. - adhere to clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461749. bob80905 added a comment. fix attempt 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/CodeGe

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461747. bob80905 added a comment. fix attempt 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h Index: clang/lib/

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461739. bob80905 added a comment. Herald added subscribers: llvm-commits, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, mravishankar, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufeng

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_intrinsics.h:18 // abs builtins -__attribute__((clang_builtin_alias(__builtin_abs))) int abs(int In); -__attribute__((clang_builtin_alias(__builtin_labs))) int64_t abs(int64_t In); The ch

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461727. bob80905 added a comment. - remove int attribute links in hlsl_intrinsics.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/h

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461725. bob80905 added a comment. - add elementwise function tests. Remove integer tests, ceil will not take integer types as an arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.l

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. For this builtin you should be able to use `__builtin_elementwise_ceil` for all the overload cases, and you should be able to add the vector cases too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://review

[PATCH] D134319: [HLSL] add ceil library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 created this revision. bob80905 added a reviewer: beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the ceil library function for