[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-23 Thread Chris Bieneman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd20f9f8d2177: [Docs] [HLSL] Add IR reference for HLSL (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134304/new/ https://reviews.llvm.or

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-22 Thread Chris Bieneman via Phabricator via cfe-commits
beanz updated this revision to Diff 462299. beanz added a comment. Updating documentation for `hlsl.uavs`, thanks @python3kgae! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134304/new/ https://reviews.llvm.org/D134304 Files: clang/docs/HLSL/HLS

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-20 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:20 + +The ``hlsl.uavs`` metadata is a list of all the global variables that represent +to UAV resources. beanz wrote: > python3kgae wrote: > > Maybe only external global variables?

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-20 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:20 + +The ``hlsl.uavs`` metadata is a list of all the global variables that represent +to UAV resources. python3kgae wrote: > Maybe only external global variables? > Do they have to be

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-20 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:20 + +The ``hlsl.uavs`` metadata is a list of all the global variables that represent +to UAV resources. Maybe only external global variables? Repository: rG LLVM Github Monor

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-20 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:12 +The goal of this document is to provide a reference for all the special purpose +IR metadata and attributes used by the HLSL code generation path. + python3kgae wrote: > Once we docu

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-20 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:12 +The goal of this document is to provide a reference for all the special purpose +IR metadata and attributes used by the HLSL code generation path. + Once we document a metadata

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

2022-09-20 Thread Chris Bieneman via Phabricator via cfe-commits
beanz created this revision. beanz added reviewers: pow2clk, python3kgae. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL uses a variety of named IR metadata and attributes to convey additional informat