[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

2022-09-19 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG924974a3a13b: [clangd] Improve inlay hints of things expanded from macros (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133982/new/

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

2022-09-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:281 - void addReturnTypeHint(FunctionDecl *D, SourceLocation Loc) { + void addReturnTypeHint(FunctionDecl *D, SourceRange Range) { auto *AT = D->getReturnType()->getContainedAutoType();

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

2022-09-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for fixing! Comment at: clang-tools-extra/clangd/InlayHints.cpp:281 - void addReturnTypeHint(FunctionDecl *D, SourceLocation Loc) { + void addReturnTypeHint(Functi

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

2022-09-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: nridge. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When we aim