Ericson2314 updated this revision to Diff 473684.
Ericson2314 added a comment.
Herald added a subscriber: Moerafaat.
Rebase, rename variables
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133890/new/
https://reviews.llvm.org/D133890
Files:
bolt/
compnerd added a comment.
I don't see anything wrong with this change per se, but I'm conflicted on the
name of the variable. These are not standard variables but are encroaching on
the CMake namespace. What happens if upstream decides to use these names? I
think that we should keep the name
Ericson2314 created this revision.
Ericson2314 added reviewers: phosek, ldionne, sebastian-ne, beanz.
Herald added subscribers: libc-commits, bzcheeseman, ayermolo, sdasgup3,
abrachet, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes,
jurahul, Kayjukh, grosul1, Joonsoo, liufen
