[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

ayzhao added a comment. In D133757#3916040 , @sammccall wrote: > In D133757#3916028 , @nridge wrote: > >> In D133757#3915995 , @ayzhao wrote: >> >>> This change is causing

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

sammccall added a comment. In D133757#3916028 , @nridge wrote: > In D133757#3915995 , @ayzhao wrote: > >> This change is causing system-include-extractor.test >>

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. In D133757#3915995 , @ayzhao wrote: > This change is causing system-include-extractor.test > > to fail on Chrome: https:

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

ayzhao added a comment. This change is causing system-include-extractor.test to fail on Chrome: https://crbug.com/1382508 The test fails on this assertion

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e230aa29f7: [clangd] Perform system include extraction inside CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Woohoo, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 __

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. In D133757#3895710 , @nridge wrote: > I will follow up with a patch to rename QueryDriverDatabase.cpp to > SystemIncludeExtractor.cpp. Posted in D137401 Repository: rG LLVM Github Monorepo

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:82 + +# Skip past the lack of diagnostics in the workspace and user config files... +# CHECK2: "method": "textDocument/publishDiagnostics", nridge wrote: > Ugh

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge updated this revision to Diff 472235. nridge added a comment. Improve handling of config file diagnostics in lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 Files: clang-tools-extra/clan

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:82 + +# Skip past the lack of diagnostics in the workspace and user config files... +# CHECK2: "method": "textDocument/publishDiagnostics", Ugh, this doesn't q

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. I believe this addresses the remaining review comments. I will follow up with a patch to rename QueryDriverDatabase.{h,cpp} to SystemIncludeExtractor,{h,cpp}. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:318 /// compilation database. -c