[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-21 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 abandoned this revision. doru1004 added a comment. The outcome of this discussion resulted in a fix to the original program from use_device_addr(x) to use_device_addr(x[:count]). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133694/new/ https://reviews.llvm.org/D133694 __

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ dreachem wrote: > ye-luo wrote: > > doru1004 wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > doru

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > doru10

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > In my

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > In my understanding of the s

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > In my understanding of the spec. > > `map(tofrom:x

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > In my understanding of the spec. > `map(tofrom:x[0:256])` only maps

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ In my understanding of the spec. `map(tofrom:x[0:256])` only maps the memory segment t

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 updated this revision to Diff 459475. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133694/new/ https://reviews.llvm.org/D133694 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 updated this revision to Diff 459452. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133694/new/ https://reviews.llvm.org/D133694 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. With the current implementation,