[PATCH] D133518: [HLSL] Call global destructors from entries

2022-09-13 Thread Chris Bieneman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa8a49923ddf7: [HLSL] Call global destructors from entries (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133518/new/ https://reviews.llv

[PATCH] D133518: [HLSL] Call global destructors from entries

2022-09-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133518#3781308 , @beanz wrote: > In D133518#3781101 , @aaron.ballman > wrote: > >> This ge

[PATCH] D133518: [HLSL] Call global destructors from entries

2022-09-09 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. In D133518#3781101 , @aaron.ballman wrote: > This generally LGTM, but to double-check: the behavior if the user does call > `atexit()` or or `at_quick_exit()` is that we simply don't call those > handlers? As opposed to something

[PATCH] D133518: [HLSL] Call global destructors from entries

2022-09-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This generally LGTM, but to double-check: the behavior if the user does call `atexit()` or or `at_quick_exit()` is that we simply don't call those handlers? As opposed to something worse like we dispatch to the handler and then crash on exit or something like that

[PATCH] D133518: [HLSL] Call global destructors from entries

2022-09-08 Thread Chris Bieneman via Phabricator via cfe-commits
beanz created this revision. beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk, tex3d, eli.friedman. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL doesn't have a C++ runtime that sup