kadircet updated this revision to Diff 458769.
kadircet added a comment.
I agree this is creating confusing state for constructors of ClangdLSPServer. It
would be interesting to create LSPServer after the initialize request one day.
- Make client-capability related options private again.
Reposi
sammccall added a comment.
I like the change to initialize() a lot.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:64
+
+/// Options used for diagnostics.
+ClangdDiagnosticOptions DiagOpts;
I don't really like making these options part of this s
kadircet updated this revision to Diff 458128.
kadircet added a comment.
rename helper & add comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D19/new/
https://reviews.llvm.org/D19
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Moves clangd
