[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2753eafe5a7f: [Clang] Fix the new driver crashing when using '-fsyntax-only' (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D133161?vs=457419&id=458332#toc Repository: rG LL

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:4396-4398 + bool SingleDeviceOutput = !llvm::any_of(OffloadActions, [](Action *A) { +return A->getType() == types::TY_Nothing; + }

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4396-4398 + bool SingleDeviceOutput = !llvm::any_of(OffloadActions, [](Action *A) { +return A->getType() == types::TY_Nothing; + }) && isa(HostAction); tra wrote: > `any_of(A->getType()

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

tra added a comment. OK. I'm going to land it then. Comment at: clang/lib/Driver/Driver.cpp:4396-4398 + bool SingleDeviceOutput = !llvm::any_of(OffloadActions, [](Action *A) { +return A->getType() == types::TY_Nothing; + }) && isa(HostAction); `any_of(A->

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

jhuber6 added a comment. In D133161#3765469 , @tra wrote: > Does this patch obviate D133133 or is it > purely for the new driver functionality? If the intent of that patch was to prevent it from emitting an error with

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

tra added a comment. Does this patch obviate D133133 or is it purely for the new driver functionality? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133161/new/ https://reviews.llvm.org/D133161 _

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The new driver currently crashses when a