[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. In D133102#3774151 , @alexfh wrote: > For example, LLVM coding standards recommends using early exits: > https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-si

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

alexfh added a comment. For example, LLVM coding standards recommends using early exits: https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133102/new/ https://rev

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. FWIW, I'm not sure this will usually be a simplification of the code. Splitting the condition and using early return is quite a frequent recommendation in code reviews, and I would e

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

njames93 updated this revision to Diff 457228. njames93 added a comment. Remove unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133102/new/ https://reviews.llvm.org/D133102 Files: clang-tools-extra/clang-tidy/readability/Simpl

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

njames93 created this revision. njames93 added reviewers: aaron.ballman, JonasToth, LegalizeAdulthood, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subsc