This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbb9dedce5d01: [Frontend] Restore
Preprocessor::getPredefines() (authored by royjacobson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
royjacobson updated this revision to Diff 457070.
royjacobson edited the summary of this revision.
royjacobson added a comment.
Add a link to github issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133044/new/
https://reviews.llvm.org/D133044
thieta accepted this revision.
thieta added a comment.
LGTM and seems pretty safe so I am not opposed to merge it before 15 final.
I would maybe add a link to the GitHub issue in the comment, but that's a nit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
brad.king accepted this revision.
brad.king added a comment.
This revision is now accepted and ready to land.
LGTM. After applying this patch locally on top of the release/15.x branch,
CastXML builds again. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
royjacobson created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
royjacobson requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A patch from May removed Preprocessor::getPredefines() from Clang's API,
