This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0cb080933654: [Clang][Comments] Parse `![]()
` in doc comments correctly (authored by egorzhdan).
Repository:
rG LLVM Github Monorepo
CHAN
egorzhdan updated this revision to Diff 456989.
egorzhdan added a comment.
Rebase to apply fixes to string conversion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132932/new/
https://reviews.llvm.org/D132932
Files:
clang/lib/AST/CommentLexer.cp
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/tools/libclang/CXString.cpp:85
+ if (String.empty())
+return createEmpty();
+
egorzhdan wrote:
> gribozavr2 wrote:
> > Ple
egorzhdan marked an inline comment as done.
egorzhdan added inline comments.
Comment at: clang/tools/libclang/CXString.cpp:85
+ if (String.empty())
+return createEmpty();
+
gribozavr2 wrote:
> Please split this change into a separate patch and add a unit tes
gribozavr2 added inline comments.
Comment at: clang/tools/libclang/CXString.cpp:85
+ if (String.empty())
+return createEmpty();
+
Please split this change into a separate patch and add a unit test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
egorzhdan marked an inline comment as done.
egorzhdan added inline comments.
Comment at: clang/test/Sema/warn-documentation.cpp:78
+/// Aaa bbb
+int test_html_img4(int);
+
gribozavr2 wrote:
> Could you also add these tests to
> clang/test/Index/comment-to-html-x
egorzhdan updated this revision to Diff 456674.
egorzhdan added a comment.
- Add tests for conversion of doc comments to HTML/XML
- Fix a bug in `StringRef` -> `CXString` conversion logic for an empty
string
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
gribozavr2 added inline comments.
Comment at: clang/test/Sema/warn-documentation.cpp:78
+/// Aaa bbb
+int test_html_img4(int);
+
Could you also add these tests to
clang/test/Index/comment-to-html-xml-conversion.cpp to show that the whole tag
is captured correct
egorzhdan created this revision.
Herald added a project: All.
egorzhdan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a valid HTML5 tag. Previously it triggered a Clang error (`HTML start
tag prematurely ended, expected attribute
