[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_intrinsics.h:18 +// abs builtins +__attribute__((clang_builtin_alias(__builtin_abs))) int abs(int In); +__attribute__((clang_builtin_alias(__builtin_labs))) int64_t abs(int64_t In); This s

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Chris Bieneman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb95c57444a8a: [HLSL] add sqrt library function (authored by bob80905, committed by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461674. bob80905 added a comment. - add empty line to end of file sqrt.hlsl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/lib/Headers/hlsl/hlsl_intr

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 ___ c

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461656. bob80905 added a comment. Include previous commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/t

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461638. bob80905 added a comment. add hlslintr.h file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h Index: clan

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461636. bob80905 added a comment. include both commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/test/CodeGenHLSL/builtins/sqrt.hlsl Index: cl

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-19 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 461405. bob80905 added a comment. rebase rebasing review to latest origin/main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/test/CodeGenHLSL/built

[PATCH] D132711: [HLSL] add sqrt library function

2022-09-07 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 458513. bob80905 added a comment. Shader Model target update Change the shader model target to 6.2, because that is when fnative-half-type was introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/n

[PATCH] D132711: [HLSL] add sqrt library function

2022-08-26 Thread Greg Roth via Phabricator via cfe-commits
pow2clk added a comment. A very minor suggestion. This looks pretty straightforward. Comment at: clang/test/CodeGenHLSL/builtins/sqrt.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s --check-prefix=NO_HALF + --

[PATCH] D132711: [HLSL] add sqrt library function

2022-08-25 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 created this revision. bob80905 added reviewers: beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the sqrt library funct