[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. In D132425#3753065 , @leonardchan wrote: > We have a generic long term solution for hwasan+RV which I think might also > be applicable for MTE+RV. For hwasan, since it's mainly the IR pass that > converts usages of the vtable (wi

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3752468 , @hctim wrote: > Glad to see that refactoring the sanitizer metadata made someone's life > easier ;) (now allowing for disabling hwasanificiation of globals) > > Patch looks reasonable to me. Can you pleas

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. Glad to see that refactoring the sanitizer metadata made someone's life easier ;) (now allowing for disabling hwasanificiation of globals) Patch looks reasonable to me. Can you please add the negative test (that vtables under the vanilla ABI still have hwasan)? I wans't

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

This revision was automatically updated to reflect the committed changes. Closed by commit rG93e5cf6b9c08: [clang] Do not instrument relative vtables under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ h

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3743276 , @mcgrathr wrote: > lgtm. > You might add some comments in CGVTables.cpp about why this is done and what > the alternatives might be in the future. Done. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan updated this revision to Diff 455423. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ https://reviews.llvm.org/D132425 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CGVTables.h clang/lib/CodeGen/ItaniumCXXABI.c

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm. You might add some comments in CGVTables.cpp about why this is done and what the alternatives might be in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan created this revision. leonardchan added reviewers: mcgrathr, eugenis, phosek, vitalybuka. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Full context in https://bugs.fuc