[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

aeubanks abandoned this revision. aeubanks added a comment. will use Eli's suggestion instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131980/new/ https://reviews.llvm.org/D131980 ___ cfe-commits ma

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

efriedma added a comment. If you're specifically concerned about sibcall (call->jmp) optimization in the backend, it might be better to adjust the backend to avoid sibcalls at -O1, as opposed to messing with optimization passes. (i.e. make -fno-optimize-sibling-calls the default at -O1.) "tai

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

aeubanks added a comment. In D131980#3726750 , @efriedma wrote: > Are you concerned about tail-call marking, or the recursive call->loop > transform? specifically tail call marking we have symbolizers that stopped displaying some frames with this chang

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

aeubanks updated this revision to Diff 453070. aeubanks added a comment. delete comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131980/new/ https://reviews.llvm.org/D131980 Files: clang/test/CodeGen/aarch64-ls64-inline-asm.c clang/test/C

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

efriedma added a comment. Are you concerned about tail-call marking, or the recursive call->loop transform? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131980/new/ https://reviews.llvm.org/D131980 ___

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM These clang tests are just awful, but I don't have the patience to fix them... Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:245 // TODO: Investigate the cost/

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

aeubanks created this revision. Herald added subscribers: kosarev, pmatos, asb, ormris, wenlei, kerbowa, arphaman, steven_wu, hiraditya, sbc100, jvesely. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald ad