[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. alexander-shaposhnikov marked an inline comment as done. Closed by commit rGd68ba43ad247: [Intrinsics] Add initial support for NonNull attribute (authored by alexander-

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

aeubanks accepted this revision. aeubanks added a comment. lgtm Commit message nit: Saying Test plan: ninja check-all isn't super useful, just mentioning the desired changes is good enough (e.g. your code snippet) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/threadlocal_address.cpp:27 // CHECK-O1-NEXT: entry: -// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.threadlocal.addre

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov marked 2 inline comments as done. alexander-shaposhnikov added inline comments. Comment at: clang/test/CodeGenCXX/threadlocal_address.cpp:27 // CHECK-O1-NEXT: entry: -// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.threadlocal.address.p0(ptr non

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/threadlocal_address.cpp:27 // CHECK-O1-NEXT: entry: -// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.threadlocal.address.p0(ptr nonnull @i) +// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.t

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov updated this revision to Diff 452615. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131872/new/ https://reviews.llvm.org/D131872 Files: clang/test/CodeGenCXX/threadl

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

ChuanqiXu added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1415 def int_threadlocal_address : DefaultAttrsIntrinsic<[llvm_anyptr_ty], [LLVMMatchType<0>], - [IntrNoMem, IntrSpeculatable, IntrWillReturn]>; +

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov updated this revision to Diff 452590. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131872/new/ https://reviews.llvm.org/D131872 Files: clang/test/CodeGenCXX/threadlocal_address.cpp llvm/include/llvm/IR/Intrinsics.td llv

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: nikic, ChuanqiXu. alexander-shaposhnikov created this object with visibility "All Users". Herald added a subscriber: pengfei. Herald added a project: All. alexander-shaposhnikov requested review of this revision.