[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

2022-08-08 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/include/clang/AST/Expr.h:3832 + llvm::Optional getICEKind() const { return IK; } + Does it need to be Optional? It seems that it is never checked that it does not hold a value except for the setter method.

[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

2022-08-08 Thread Justin Stitt via Phabricator via cfe-commits
justinstitt updated this revision to Diff 450966. justinstitt retitled this revision from "[Clang][BinaryOperator] cache ICEKind" to "[Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs". justinstitt edited the summary of this revision. justinstitt added a comment. Herald added a subs