[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

2022-08-08 Thread Justin Stitt via Phabricator via cfe-commits
justinstitt updated this revision to Diff 450964. justinstitt added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131416/new/ https://reviews.llvm.org/D131416 Files: clang/include/clang/AST/Expr.h clang/lib/AST

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

2022-08-08 Thread Justin Stitt via Phabricator via cfe-commits
justinstitt updated this revision to Diff 450961. justinstitt marked 7 inline comments as done. justinstitt added a comment. create getter/setter for optional ICEKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131416/new/ https://reviews.llvm.or

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

2022-08-08 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/include/clang/AST/Expr.h:30 #include "clang/Basic/TypeTraits.h" +#include "llvm/ADT/Optional.h" #include "llvm/ADT/APFloat.h" Please keep the list of `#include`s alphabetically sorted.

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

2022-08-08 Thread Justin Stitt via Phabricator via cfe-commits
justinstitt updated this revision to Diff 450872. justinstitt edited the summary of this revision. justinstitt added a reviewer: nickdesaulniers. justinstitt added a comment. - test adding reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1314

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

2022-08-08 Thread Justin Stitt via Phabricator via cfe-commits
justinstitt created this revision. Herald added a project: All. justinstitt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Justin Stitt Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131416 Files: cla