justinstitt updated this revision to Diff 450964.
justinstitt added a comment.
update commit message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131416/new/
https://reviews.llvm.org/D131416
Files:
clang/include/clang/AST/Expr.h
clang/lib/AST
justinstitt updated this revision to Diff 450961.
justinstitt marked 7 inline comments as done.
justinstitt added a comment.
create getter/setter for optional ICEKind
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131416/new/
https://reviews.llvm.or
nickdesaulniers added inline comments.
Comment at: clang/include/clang/AST/Expr.h:30
#include "clang/Basic/TypeTraits.h"
+#include "llvm/ADT/Optional.h"
#include "llvm/ADT/APFloat.h"
Please keep the list of `#include`s alphabetically sorted.
justinstitt updated this revision to Diff 450872.
justinstitt edited the summary of this revision.
justinstitt added a reviewer: nickdesaulniers.
justinstitt added a comment.
- test adding reviewers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1314
justinstitt created this revision.
Herald added a project: All.
justinstitt requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Signed-off-by: Justin Stitt
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D131416
Files:
cla