[PATCH] D131258: [Sema] Merge variable template specializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ilya-biryukov marked 2 inline comments as done. Closed by commit rG07529996d92b: [Sema] Merge variable template specializations (authored by ilya-biryukov). Changed pr

[PATCH] D131258: [Sema] Merge variable template specializations

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM then. Comment at: clang/test/Modules/merge-var-template-spec-cxx-modules.cpp:18-23 +template constexpr T zero = 0; // expected-error-re {{declaration{{.*}}in the

[PATCH] D131258: [Sema] Merge variable template specializations

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. In D131258#3705503 , @ChuanqiXu wrote: > When I run this locally, it emits several unexpected errors: Sorry, my bad. I was testing this with `-std=c++20` and later switched to

[PATCH] D131258: [Sema] Merge variable template specializations

ilya-biryukov updated this revision to Diff 450770. ilya-biryukov added a comment. - Add the forgotten `-fmodules-local-submodule-visibility` flag to the test - Add newlines to the test files - Switch to C++14 mode for tests, they don't use C++17. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D131258: [Sema] Merge variable template specializations

ChuanqiXu added inline comments. Comment at: clang/test/Modules/merge-var-template-spec-cxx-modules.cpp:18-23 +template constexpr T zero = 0; // expected-error-re {{declaration{{.*}}in the global module follows declaration in module var_def}} +

[PATCH] D131258: [Sema] Merge variable template specializations

ChuanqiXu added a comment. When I run this locally, it emits several unexpected errors: While building module 'library': In file included from :2: /disk2/workspace.xuchuanqi/llvm-project-for-work/build/tools/clang/test/Modules/Output/merge-var-template-spec.cpp.tmp/var2.h:4:32: error: red

[PATCH] D131258: [Sema] Merge variable template specializations

inclyc added inline comments. Comment at: clang/test/Modules/merge-var-template-spec-cxx-modules.cpp:45 +export import var_def; \ No newline at end of file Missing newline Comment at: clang/test/Modules/merge-var-template-spec.cpp:68 +#endif /

[PATCH] D131258: [Sema] Merge variable template specializations

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Clang used to produce redefinition errors, see tests for examples. Repository: rG LLVM Github Monorepo h