This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8b74074731ee: [clang][sema] Fix collectConjunctionTerms()
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D131070?vs=4499
tbaeder added a comment.
FWIW I switched it around so _this_ patch is now good as-is while
https://reviews.llvm.org/D130894 now depends on this one.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131070/new/
https://reviews.llvm.org/D131070
_
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Oh shoot, I saw that precommit CI made it past patch application failing (last
time) and I thought the precommit CI bug was fixed and so it was testing the
whole stack for once.
tbaeder updated this revision to Diff 449930.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131070/new/
https://reviews.llvm.org/D131070
Files:
clang/lib/Sema/SemaTemplate.cpp
Index: clang/lib/Sema/SemaTemplate.cpp
===
-
tbaeder added a comment.
That's just because of the note that https://reviews.llvm.org/D130894 adds,
which the patch expects.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131070/new/
https://reviews.llvm.org/D131070
aaron.ballman added a comment.
It looks like precommit CI caught a relevant issue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131070/new/
https://reviews.llvm.org/D131070
___
cfe-commits mailing list
c
tbaeder created this revision.
tbaeder added a reviewer: aaron.ballman.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Consider:
A == 5 && A != 5
IfA is 5, the old collectConjunctionTerms() would call
