Anastasia closed this revision.
Anastasia added a comment.
r248906 and r250892
http://reviews.llvm.org/D13105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia updated this revision to Diff 35732.
Anastasia added a comment.
Thanks! The review comments are addressed in this update!
http://reviews.llvm.org/D13105
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/Specifiers.h
lib/AST/Decl.cpp
lib/AST/DeclPrinter.cpp
bader added a subscriber: bader.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7472-7473
@@ -7469,4 +7471,4 @@
"sampler type cannot be used with the __local and __global address space
qualifiers">;
def err_opencl_global_invalid_addr_space : Error<
- "global variable
pekka.jaaskelainen requested changes to this revision.
pekka.jaaskelainen added a comment.
This revision now requires changes to proceed.
Could only find style nitpicks in this one.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7473
@@ -7470,3 +7472,3 @@
def err_opencl
Anastasia created this revision.
Anastasia added a reviewer: pekka.jaaskelainen.
Anastasia added a subscriber: cfe-commits.
I would like to commit this change that enables program scope variables (PSVs)
– an OpenCL2.0 feature (Section 6.5.1).
There are three major changes in this patch.
First c
