[PATCH] D130974: [analyzer] Fix for the crash in #56873

2022-08-10 Thread Domján Dániel via Phabricator via cfe-commits
isuckatcs added a comment. > If so, shouldn't be some dependencies across these revisions? I don't think they are that closely related. This patch is about fixing an assertion failure. This assertion failure happens because we don't handle a case not because the checker doesn't exist. Also the

[PATCH] D130974: [analyzer] Fix for the crash in #56873

2022-08-10 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D130974#3709502 , @isuckatcs wrote: >> Some checker should have caught the uninitialized value earlier than the >> defaultEvalCall(). >> I guess, the MallocCkecher could have checked for it in PreStmt. >> Or alternatively, th

[PATCH] D130974: [analyzer] Fix for the crash in #56873

2022-08-09 Thread Domján Dániel via Phabricator via cfe-commits
isuckatcs added a comment. > Some checker should have caught the uninitialized value earlier than the > defaultEvalCall(). > I guess, the MallocCkecher could have checked for it in PreStmt. > Or alternatively, the CallAndMessageChecker::preCall() already does something > like this in the PreVisi

[PATCH] D130974: [analyzer] Fix for the crash in #56873

2022-08-09 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Some checker should have caught the uninitialized value earlier than the `defaultEvalCall()`. I guess, the `MallocCkecher` could have checked for it in `PreStmt`. Or alternatively, the `CallAndMessageChecker::preCall()` already does something like this in the `PreVisitP

[PATCH] D130974: [analyzer] Fix for the crash in #56873

2022-08-03 Thread Domján Dániel via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG10a7ee0bac21: [analyzer] Fix for the crash in #56873 (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LA