This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG98cf745a032e: [clang] Only modify FileEntryRef names that
are externally remapped (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
benlangmuir updated this revision to Diff 449124.
benlangmuir added a comment.
Flip the order of comparisons to avoid unnecessary string comparisons.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130935/new/
https://reviews.llvm.org/D130935
Files:
benlangmuir added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:277-278
- if (Status.getName() == Filename) {
-// The name matches. Set the FileEntry.
+ if (Status.getName() == Filename || !Status.ExposesExternalVFSPath) {
+// Use the requested name. Se
bnbarham accepted this revision.
bnbarham added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Basic/FileManager.cpp:277-278
- if (Status.getName() == Filename) {
-// The name matches. Set the FileEntry.
+ if (Status.getName() == F
benlangmuir created this revision.
benlangmuir added reviewers: bnbarham, jansvoboda11.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As progress towards having FileEntryRef contain the requested n
