[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. In D130531#4644687 , @aeubanks wrote: > I'm not understanding why this doesn't also apply to "PIE Level", doesn't it > also follow the same reasoning? pic -> PIC is the same as pie -> PIE > > e.g. if you merge a small PIC and lar

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

aeubanks added a comment. I'm not understanding why this doesn't also apply to "PIE Level", doesn't it also follow the same reasoning? pic -> PIC is the same as pie -> PIE e.g. if you merge a small PIC and large PIC file, the resulting file would only be guaranteed to work with a "large PIC exe

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2a38887932e: [IR] Use Min behavior for module flag "PIC Level" (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D130531?v

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 _

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay updated this revision to Diff 453806. MaskRay added a comment. add Bitcode/upgrade-pic-level.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 Files: clang/test/CodeGen/piclevels.c llvm/lib/I

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

tejohnson added a comment. Looked into this a bit and the change does also seem correct to me. One comment: I see a test checking the upgrade behavior from the old Error type, but not for the upgrade from Max to Min. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. @tmsriram Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

tejohnson added a comment. @tmsriram can you take a look? I can review from a code standpoint but you are more familiar with PIC/PIE details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 _

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay created this revision. MaskRay added reviewers: davide, tejohnson. Herald added subscribers: StephenFan, okura, kuter, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added proje