[PATCH] D130516: compression classes

dblaikie added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new llvm::compression::ZlibCompressionAlgorithm(); + ckissane wrote: > dblaikie wrote: >

[PATCH] D130516: compression classes

ckissane added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new llvm::compression::ZlibCompressionAlgorithm(); + dblaikie wrote: > We're generally tr

[PATCH] D130516: compression classes

ckissane updated this revision to Diff 448181. ckissane added a comment. - use CompressionScheme->notNone() in InstrProf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/i

[PATCH] D130516: compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54 + CompressionScheme = + CompressionScheme->when(Compress && DoInstrProfNameCompression) + ->whenSupported(); note the helpers such as when(bool),

[PATCH] D130516: compression classes

ckissane updated this revision to Diff 448176. ckissane added a comment. - fix compression inheritence and some more compression class helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clan

[PATCH] D130516: compression classes

ckissane added a comment. In D130516#3683384 , @dblaikie wrote: > Any chance this could be split up to be more directly comparable to > https://reviews.llvm.org/D130458 ? yes definitely! Doing so now! Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D130516: compression classes

dblaikie added a comment. Any chance this could be split up to be more directly comparable to https://reviews.llvm.org/D130458 ? Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new ll