This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2a88fb2ecb72: [pseudo] Eliminate the dangling-else syntax
ambiguity. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
hokein updated this revision to Diff 446728.
hokein added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130160/new/
https://reviews.llvm.org/D130160
Files:
clang-tools-extra/pseudo/include/clang-pseudo/Language.h
clang-tools-
hokein added inline comments.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:25
+ const TokenStream &Tokens;
+ SymbolID Lookahead;
+};
sammccall wrote:
> passing the position in the stream would be more general, there's no reason
> in par
hokein updated this revision to Diff 446388.
hokein marked 2 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130160/new/
https://reviews.llvm.org/D130160
Files:
clang-tools-extra/p
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:25
+ const TokenStream &Tokens;
+ SymbolID Lookahead;
+};
passing the positi
hokein created this revision.
hokein added a reviewer: usaxena95.
Herald added a project: All.
hokein requested review of this revision.
Herald added a subscriber: alextsao1999.
Herald added a project: clang-tools-extra.
- the grammar ambiguity is eliminate by a guard;
- modify the guard function
