[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-26 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde1b5c91453f: [AArch64] Simplify BTI/PAC-RET module flags (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D130145?vs=4473

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-26 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. AutoUpgrade is added due to similar issue at a user. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/ https://reviews.llv

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 447387. MaskRay edited the summary of this revision. MaskRay added a comment. Keep AutoUpgrade.cpp code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/ https://reviews.llvm.org/D130145 Files: clang

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min.

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-25 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min. -if (ID->getString() == "branch-ta

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min.

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-22 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min. -if (ID->getString() == "branch-ta

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 446053. MaskRay added a comment. remove a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/ https://reviews.llvm.org/D130145 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/aarch

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: danielkiss, pcc. Herald added subscribers: StephenFan, hiraditya, kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, s