[PATCH] D130081: Add foldings for multi-line comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef11616b228: Add foldings for multi-line comment. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.o

[PATCH] D130081: Add foldings for multi-line comment.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:177 -// FIXME(kirillbobyrev): Collect comments, PP conditional regions, includes and -// other code regions (

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447928. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clangd/Protocol.cpp clang

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:232 +while (T != Tokens.end() && T->Kind == tok::comment && + LastComment->Line == T->Line + 1) { + LastComment = T; hokein wrote: > this seems incorrec

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447926. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-to

[PATCH] D130081: Add foldings for multi-line comment.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:1782 unsigned endCharacter; - std::string kind; + FoldingRangeKind kind; }; hokein wrote: > sorry for not being clear on my previous comment, I think the current `string > kind

[PATCH] D130081: Add foldings for multi-line comment.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:1782 unsigned endCharacter; - std::string kind; + FoldingRangeKind kind; }; sorry for not being clear on my previous comment, I think the current `string kind;` is good, and it a

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 445893. usaxena95 added a comment. Do not fill Kind in JSON when it is unspecified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clang

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:351 +int c; +[[// A comment +// expanding more than hokein wrote: > For this case, my personal preference would be to have 3 differ

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 445890. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-to

[PATCH] D130081: Add foldings for multi-line comment.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:176 // FIXME(kirillbobyrev): Collect comments, PP conditional regions, includes and // other code regions (e.g. public/private/protected sections of classes, nit: update

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or