This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61fa7a88c7b6: [clang][OpenMP] Add IRBuilder support for
taskgroup (authored by shraiysh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
shraiysh updated this revision to Diff 446355.
shraiysh added a comment.
Rebase with main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129992/new/
https://reviews.llvm.org/D129992
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
clang/test/OpenMP/ta
Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5207-5209
+ if (T.clauses().size() > 0)
+return false;
+ return true;
simplification
Repo
shraiysh added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209
+ OMPLexicalScope Scope(*this, S, OMPD_unknown);
+ if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) {
+llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBuild
shraiysh updated this revision to Diff 445697.
shraiysh added a comment.
Moved checking to `isSupportedByOpenMPIRBuilder`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129992/new/
https://reviews.llvm.org/D129992
Files:
clang/lib/CodeGen/CGStmt
Meinersbur added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209
+ OMPLexicalScope Scope(*this, S, OMPD_unknown);
+ if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) {
+llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBui
shraiysh created this revision.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
shraiysh requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
This patch makes use of OMPIRBuil
